andygrove commented on PR #17561: URL: https://github.com/apache/datafusion/pull/17561#issuecomment-3334340951
> > Tried taking an initial look but the PR is quite massive so a full review will take quite a while. I left some initial notes, but some more overall notes: > > @andygrove or @shehabgamin -- do you have any insight to how other rust libraries handle java formatting strings? Is this something that already exists in the comet or Lakesail codebase that we could migrate (or borrow tests for?) We haven't implemented this function in Comet. It hasn't been a priority for us. Also, because Comet is hybrid JVM/Rust with zero copy, I don't know if we would implement this in JVM or native code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
