wForget commented on issue #2448: URL: https://github.com/apache/datafusion-comet/issues/2448#issuecomment-3342165077
> I dont see normalized code is called, checking https://github.com/apache/datafusion-comet/blob/03c062646ba183069b2fd252df23d00e1f2e51c8/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala#L575-L578 As mentioned in the comment, `SQLOrderingUtil.compareFloats` is used in vanilla Spark to compare float types without normalization. <img width="1485" height="779" alt="Image" src="https://github.com/user-attachments/assets/4cd69479-7624-4069-ad9e-ce4f78b183ce"; /> We might be able to simply fix this by wrapping `NormalizeNaNAndZero` in the `min/max` agg for float types in comet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
