timsaucer commented on issue #513:
URL: 
https://github.com/apache/datafusion-python/issues/513#issuecomment-3358403617

   From a user experience perspective, we have this issue which has 
parameterized queries like:
   
   ```
   ctx.sql("select c_custkey, c_name from {df}", df=df_customer)
   ```
   
   And the similar query for direct injection would be
   
   ```
   ctx.sql("select c_custkey, c_name from df_customer")
   ```
   
   As Matt points out above we could potentially do replacement of things other 
than table names with the parameterization.
   
   From an implementation perspective, the parameterization approach searches 
any SQL command for `{}` and matching named arguments and does a replacement 
with their string equivalent of their logical plan.
   
   The direct injection tries to execute the SQL command, and on failures then 
tries to find objects that can be table providers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to