EeshanBembi commented on code in PR #17867:
URL: https://github.com/apache/datafusion/pull/17867#discussion_r2399590109
##########
datafusion-cli/src/progress/estimator.rs:
##########
Review Comment:
@xudong963 Good call on the documentation! I've added much more detailed
explanations for the
Kalman filter implementation.
Now includes:
- Full breakdown of the 2D state vector model and how it tracks
`[progress_rate,
acceleration]`
- Explanation of the state transition and measurement models
- Step-by-step walkthrough of the prediction and update equations
- Clear guidance on tuning the noise parameters (with recommended ranges)
You can check it out in `datafusion-cli/src/progress/estimator.rs` around
lines 91-130. Should
be much easier for reviewers and future maintainers to understand what's
going on under the
hood!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
