comphead commented on PR #2515: URL: https://github.com/apache/datafusion-comet/pull/2515#issuecomment-3366308072
> > Thanks @andygrove > > Its been a while since `backtraces` introduced in DF and I was thinking to replace Comet errors with DFs? So they would have backtrace capabilities and would be easier to navigate through Comet and DF, WDYT? > > I don't know enough about this. Would you mind writing up an issue to explain in more detail? DataFusion uses error macros (for example `exec_err!` wraps `ExecutionError`) which wraps the error and adds the backtrace if needed. It works in DF as gives approximation on root cause. But what comes to my mind now is: DF backtrace should include Comet entrypoint anyway, because it is caller code, so we don't really need to use error macros in Comet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
