metegenez commented on code in PR #1320:
URL:
https://github.com/apache/datafusion-ballista/pull/1320#discussion_r2413131863
##########
ballista/client/tests/context_checks.rs:
##########
@@ -935,4 +935,45 @@ mod supported {
Ok(())
}
+
+ // at the moment sort merge join is not supported due to
+ // serde issues. it should be supported with DF.50
Review Comment:
Comments might be outdated.
##########
ballista/client/tests/context_checks.rs:
##########
@@ -935,4 +935,45 @@ mod supported {
Ok(())
}
+
+ // at the moment sort merge join is not supported due to
+ // serde issues. it should be supported with DF.50
+ #[rstest]
+ #[case::standalone(standalone_context())]
+ #[case::remote(remote_context())]
+ #[tokio::test]
+ async fn should_support_sort_merge_join(
Review Comment:
Test should include some asserting for future-proofness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
