andygrove commented on code in PR #2538:
URL: https://github.com/apache/datafusion-comet/pull/2538#discussion_r2420764390
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -515,10 +515,19 @@ object CometConf extends ShimCometConf {
"'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global',
'fair_spill_global', " +
"and `unbounded`. When running Spark in off-heap mode, available pool
types are " +
"'greedy_unified' and `fair_unified`. The default pool type is
`greedy_task_shared` " +
- s"for on-heap mode and `unified` for off-heap mode. $TUNING_GUIDE.")
+ s"for on-heap mode and `fair_unified` for off-heap mode.
$TUNING_GUIDE.")
.stringConf
.createWithDefault("default")
+ val COMET_EXEC_MEMORY_POOL_FRACTION: ConfigEntry[Double] =
+ conf("spark.comet.exec.memoryPool.fraction")
+ .doc(
+ "Fraction of off-heap memory pool that is available to Comet. " +
+ "Only applies to off-heap mode. " +
+ s"$TUNING_GUIDE.")
+ .doubleConf
+ .createWithDefault(1.0)
Review Comment:
Default is 1.0 so that this change is not a breaking change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
