martin-g opened a new pull request, #18048: URL: https://github.com/apache/datafusion/pull/18048
Follow-up of https://github.com/apache/datafusion/pull/17726#pullrequestreview-3289115878 ## Which issue does this PR close? - Closes #18047 ## Rationale for this change Using `Some(true)`, `Some(false)` and `None` for the number of nulls in an array are not very clear. Using an enum with a well named variants is clearer. ## What changes are included in this PR? Introduce a local scoped enum for the needs of the function. ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> The change reuses the tests from #18047 ## Are there any user-facing changes? No <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
