vegarsti commented on code in PR #17891:
URL: https://github.com/apache/datafusion/pull/17891#discussion_r2431253483


##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -145,6 +145,7 @@ impl ScalarUDFImpl for ArrayHas {
                     let list = scalar_values
                         .into_iter()
                         .flatten()
+                        .flatten()

Review Comment:
   Sorry, are you saying you don't think it's worth adding your suggested fix 
because it's code people don't look at much, or that it's fine to add it even 
if it is slightly less performant because it's not in the hot path? 😄 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to