vegarsti commented on PR #17891: URL: https://github.com/apache/datafusion/pull/17891#issuecomment-3383292470
Reverted back to using `flatten` in d9aa726, now back to having ~same performance as on main (slightly better than on main): ``` # ./bench.sh compare main convert-array-to-scalar-vec-optional Comparing main and convert-array-to-scalar-vec-optional -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ convert-array-to-scalar-vec-optional ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 75.02 ms │ 77.72 ms │ no change │ │ QQuery 2 │ 21.47 ms │ 21.94 ms │ no change │ │ QQuery 3 │ 33.10 ms │ 34.15 ms │ no change │ │ QQuery 4 │ 25.09 ms │ 24.66 ms │ no change │ │ QQuery 5 │ 53.54 ms │ 53.55 ms │ no change │ │ QQuery 6 │ 22.10 ms │ 22.11 ms │ no change │ │ QQuery 7 │ 73.68 ms │ 73.33 ms │ no change │ │ QQuery 8 │ 48.50 ms │ 45.75 ms │ +1.06x faster │ │ QQuery 9 │ 65.69 ms │ 65.30 ms │ no change │ │ QQuery 10 │ 48.25 ms │ 47.06 ms │ no change │ │ QQuery 11 │ 16.03 ms │ 16.26 ms │ no change │ │ QQuery 12 │ 32.05 ms │ 31.61 ms │ no change │ │ QQuery 13 │ 37.23 ms │ 36.88 ms │ no change │ │ QQuery 14 │ 26.97 ms │ 28.53 ms │ 1.06x slower │ │ QQuery 15 │ 38.11 ms │ 37.94 ms │ no change │ │ QQuery 16 │ 14.98 ms │ 14.06 ms │ +1.07x faster │ │ QQuery 17 │ 95.52 ms │ 89.33 ms │ +1.07x faster │ │ QQuery 18 │ 104.07 ms │ 102.60 ms │ no change │ │ QQuery 19 │ 44.68 ms │ 43.64 ms │ no change │ │ QQuery 20 │ 33.32 ms │ 33.89 ms │ no change │ │ QQuery 21 │ 77.52 ms │ 78.33 ms │ no change │ │ QQuery 22 │ 11.18 ms │ 12.61 ms │ 1.13x slower │ └──────────────┴───────────┴──────────────────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩ │ Total Time (main) │ 998.12ms │ │ Total Time (convert-array-to-scalar-vec-optional) │ 991.26ms │ │ Average Time (main) │ 45.37ms │ │ Average Time (convert-array-to-scalar-vec-optional) │ 45.06ms │ │ Queries Faster │ 3 │ │ Queries Slower │ 2 │ │ Queries with No Change │ 17 │ │ Queries with Failure │ 0 │ └─────────────────────────────────────────────────────┴──────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
