kosiew commented on PR #17773: URL: https://github.com/apache/datafusion/pull/17773#issuecomment-3349880219
@comphead > would be that possible to have e2e slt tests? Thanks for the suggestion! At the moment this PR just introduces the CastColumnExpr building block plus its focused unit coverage, without wiring it into the planner or schema-adapter path that SQLLogicTest exercises. It's the first sub-issue of #17330 Until that follow-up lands, there isn’t a SQL surface that would actually emit this node, so an SLT case would stay unreachable and wouldn’t add new signal. Once we hook the adapter/planner up to construct CastColumnExpr, I agree that an end-to-end SLT is the right next step and I’ll plan to cover it in that integration change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
