jonathanc-n commented on code in PR #17999:
URL: https://github.com/apache/datafusion/pull/17999#discussion_r2417416312
##########
datafusion/execution/src/object_store.rs:
##########
@@ -154,6 +154,10 @@ pub trait ObjectStoreRegistry: Send + Sync +
std::fmt::Debug + 'static {
store: Arc<dyn ObjectStore>,
) -> Option<Arc<dyn ObjectStore>>;
+ /// Deregister the store previously registered with the same key. Returns
the
+ /// deregistered store if it existed.
+ fn deregister_store(&self, url: &Url) -> Result<Arc<dyn ObjectStore>>;
Review Comment:
This is breaking, we can add a label. I'm thinking maybe we can have a
default return value and remove it in another version but I don't know what
would be a good default return value (I was thinking of just erroring).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
