dqkqd commented on issue #16678: URL: https://github.com/apache/datafusion/issues/16678#issuecomment-3417548918
> From https://github.com/apache/datafusion/pull/16639/files#r2213084931, I think what we want is to have to_timestamp(double) return something like this: > SELECT to_timestamp(1.1); +-------------------------------+ | to_timestamp(Float64(1.1)) | +-------------------------------+ | 1970-01-01T00:00:00.000000001 | +-------------------------------+ I was wrong, actually `to_timestamp` should just cast as second instead of nanoseconds. I will just add the testcase, no other changes needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
