etseidl commented on code in PR #17888:
URL: https://github.com/apache/datafusion/pull/17888#discussion_r2423251292
##########
datafusion-cli/src/main.rs:
##########
@@ -585,9 +585,9 @@ mod tests {
+-----------------------------------+-----------------+---------------------+------+------------------+
| filename | file_size_bytes |
metadata_size_bytes | hits | extra |
+-----------------------------------+-----------------+---------------------+------+------------------+
- | alltypes_plain.parquet | 1851 | 10181
| 2 | page_index=false |
- | alltypes_tiny_pages.parquet | 454233 | 881418
| 2 | page_index=true |
- | lz4_raw_compressed_larger.parquet | 380836 | 2939
| 2 | page_index=false |
+ | alltypes_plain.parquet | 1851 | 7166
| 2 | page_index=false |
Review Comment:
Oh, and the column index should also be much smaller since we transposed it
from an array of structs to a struct of arrays. `alltypes_tiny_pages.parquet`
has an insane number of pages, so any savings in the column index will be
magnified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
