andygrove commented on code in PR #2538:
URL: https://github.com/apache/datafusion-comet/pull/2538#discussion_r2427789461
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -513,19 +516,39 @@ object CometConf extends ShimCometConf {
val COMET_ENABLE_ONHEAP_MODE: ConfigEntry[Boolean] =
conf("spark.comet.exec.onHeap.enabled")
.doc("Whether to allow Comet to run in on-heap mode. Required for
running Spark SQL tests.")
+ .internal()
.booleanConf
.createWithDefault(sys.env.getOrElse("ENABLE_COMET_ONHEAP",
"false").toBoolean)
- val COMET_EXEC_MEMORY_POOL_TYPE: ConfigEntry[String] =
conf("spark.comet.exec.memoryPool")
+ val COMET_EXEC_OFFHEAP_MEMORY_POOL_TYPE: ConfigEntry[String] = conf(
+ "spark.comet.exec.memoryPool")
+ .doc(
+ "The type of memory pool to be used for Comet native execution " +
+ "when running Spark in off-heap mode. Available pool types are
'greedy', 'fair_spill', " +
+ "'greedy_task_shared', 'fair_spill_task_shared', 'greedy_global',
'fair_spill_global', " +
+ s"and `unbounded`. $TUNING_GUIDE.")
+ .stringConf
+ .createWithDefault("fair_unified")
+
+ val COMET_EXEC_ONHEAP_MEMORY_POOL_TYPE: ConfigEntry[String] = conf(
+ "spark.comet.exec.onHeap.memoryPool")
.doc(
- "The type of memory pool to be used for Comet native execution. " +
- "When running Spark in on-heap mode, available pool types are
'greedy', 'fair_spill', " +
+ "The type of memory pool to be used for Comet native execution " +
+ "hen running Spark in on-heap mode. Available pool types are 'greedy',
'fair_spill', " +
Review Comment:
Yes, thanks. :chicken:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
