Jefffrey commented on PR #17178: URL: https://github.com/apache/datafusion/pull/17178#issuecomment-3345643692
> I disabled the lint for tests at the crate level to handle inline tests, but it would need to be done within each actual test file to fix everything. Running into a similar issue for whether to fix the lint errors for examples/benchmarks or disable the lint. > > Given the above, this is getting to be quite a lot of duplicate code pasted around. Options: > > * Is there a way to disable the lint at a workspace-level for tests that I am missing? > > * Should this be abandoned altogether? Maybe we can just apply the fix for benches+tests regardless? To keep things consistent with the rest of the codebase 🤔 Are there any downsides other than the number of changes required (+ potential verbosity)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
