tobixdev commented on code in PR #16985:
URL: https://github.com/apache/datafusion/pull/16985#discussion_r2427249929
##########
datafusion/physical-plan/src/unnest.rs:
##########
@@ -99,11 +107,64 @@ impl UnnestExec {
/// This function creates the cache object that stores the plan properties
such as schema, equivalence properties, ordering, partitioning, etc.
fn compute_properties(
input: &Arc<dyn ExecutionPlan>,
+ list_column_indices: &[ListUnnest],
+ struct_column_indices: &[usize],
schema: SchemaRef,
) -> PlanProperties {
+ let list_column_indices: Vec<usize> = list_column_indices
+ .iter()
+ .map(|list_unnest| list_unnest.index_in_input_schema)
+ .collect();
+ let non_unnested_indices: Vec<usize> = input
+ .schema()
+ .fields()
+ .iter()
+ .enumerate()
+ .filter(|(idx, _)| {
+ !list_column_indices.contains(idx) &&
!struct_column_indices.contains(idx)
Review Comment:
Yeah I'd only change that if its easy to do with similar complexity. I think
the quadratic behavior only makes a problem if we have many many columns and
most of them use `unnest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
