2010YOUY01 opened a new pull request, #17754:
URL: https://github.com/apache/datafusion/pull/17754

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #.
   
   ## Rationale for this change
   
   <!--
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.  
   -->
   
   It's common to see developers complain that DataFusion takes too long to 
compile or that the generated binary size is too large.
   
   This benchmark makes it easier to experiment with ways to speed up 
compilation and reduce binary size.
   
   The `compile_profile` benchmark does:
   1. Compile the benchmark runner, and also compiles its `datafusion` 
dependency, and measures the compilation time.
   2. Run the `tpch` benchmark, measure the binary execution speed
   3. Measure the size of the binaries from compilation.
   
   ### Result
   ```
   Summary
   Profile             Compile         Run        Size
   ---------------------------------------------------
   dev                  67.30s      10.17s     213.3MB
   release             476.18s       0.87s      53.6MB
   ci                   64.85s       6.89s     172.4MB
   release-nonlto      150.25s       0.95s     104.2MB
   ```
   
   Now each profile behaves as expected. In the future, we can further tweak 
the cargo profile configurations or try optimizations to make compilation 
faster.
   
   ## What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   1. Added a python script for the benchmark described above
   2. Integrate that bench script into `bench.sh`, with benchmark README 
updated.
   3. More doc in `cargo.toml` to explain compilation profiles.
   
   ## Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   5. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   Tested locally with:
   ```sh
   -- in <df-root>/benchmarks
   ./bench.sh run compile_profile
   ```
   See above `result` for its output.
   
   ## Are there any user-facing changes?
   
   No.
   <!--
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to