alamb commented on code in PR #17951:
URL: https://github.com/apache/datafusion/pull/17951#discussion_r2411314001
##########
datafusion/core/tests/physical_optimizer/test_utils.rs:
##########
@@ -142,37 +142,49 @@ pub(crate) fn parquet_exec_with_stats(file_size: u64) ->
Arc<DataSourceExec> {
}
pub fn schema() -> SchemaRef {
- Arc::new(Schema::new(vec![
- Field::new("a", DataType::Int64, true),
- Field::new("b", DataType::Int64, true),
- Field::new("c", DataType::Int64, true),
- Field::new("d", DataType::Int32, true),
- Field::new("e", DataType::Boolean, true),
- ]))
+ static SCHEMA: LazyLock<SchemaRef> = LazyLock::new(|| {
+ Arc::new(Schema::new(vec![
+ Field::new("a", DataType::Int64, true),
+ Field::new("b", DataType::Int64, true),
+ Field::new("c", DataType::Int64, true),
+ Field::new("d", DataType::Int32, true),
+ Field::new("e", DataType::Boolean, true),
+ ]))
+ });
+ Arc::clone(&SCHEMA)
Review Comment:
Now each call to `schema()` clones an `Arc` rather than actually recreating
the schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
