comphead commented on code in PR #2568:
URL: https://github.com/apache/datafusion-comet/pull/2568#discussion_r2430214589
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -79,6 +89,7 @@ object CometConf extends ShimCometConf {
.createWithDefault(sys.env.getOrElse("ENABLE_COMET", "true").toBoolean)
val COMET_NATIVE_SCAN_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.scan.enabled")
Review Comment:
the param name convention can be `${Category.SCAN}_come_val` so it would
give a consistency across naming and understanging of category
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
