andygrove commented on code in PR #2568:
URL: https://github.com/apache/datafusion-comet/pull/2568#discussion_r2430552939
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -79,6 +89,7 @@ object CometConf extends ShimCometConf {
.createWithDefault(sys.env.getOrElse("ENABLE_COMET", "true").toBoolean)
val COMET_NATIVE_SCAN_ENABLED: ConfigEntry[Boolean] =
conf("spark.comet.scan.enabled")
Review Comment:
Yes, if we had consistent names, then we wouldn't need the separate category
field. Renaming all of the configs would be pretty disruptive for users,
though. Perhaps we could consider doing this for the 1.0.0 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
