alamb opened a new pull request, #17905:
URL: https://github.com/apache/datafusion/pull/17905
## Which issue does this PR close?
## Rationale for this change
Let's keep datafusion tests efficient
Every test binary requires additional build time and space. Thus we should
have fewer test binaries.
For example the apply_schema_adapter_tests test binary is 71MB on disk after
building
```shell
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion2$ cargo test --test
apply_schema_adapter_tests
Compiling darling_core v0.21.3
...
test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out;
finished in 0.00s
andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion2$ du -h
target/debug/deps/apply_schema_adapter_tests-2091667b2c1cdecb
71M target/debug/deps/apply_schema_adapter_tests-2091667b2c1cdecb
```
But contains only a single test. Let's combine that with the existing schema
adapter tests to make testing faster and more efficient
## What changes are included in this PR?
1. Consolidate schema adapter tests
## Are these changes tested?
By CI
I also verified the test sill runs like this:
```shell
cargo test --test parquet_config -- schema_adapter
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.18s
Running tests/parquet_config.rs
(target/debug/deps/parquet_config-8b16110c71abdb9a)
running 3 tests
test parquet::schema_adapter::test_apply_schema_adapter_without_factory ...
ok
test parquet::schema_adapter::test_apply_schema_adapter_with_factory ... ok
test
parquet::schema_adapter::test_custom_schema_adapter_and_custom_expression_adapter
... ok
test result: ok. 3 passed; 0 failed; 0 ignored; 0 measured; 181 filtered
out; finished in 0.01s
```
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
