wForget commented on code in PR #2425:
URL: https://github.com/apache/datafusion-comet/pull/2425#discussion_r2425107484
##########
spark/src/test/spark-3.5/org/apache/spark/sql/CometToPrettyStringSuite.scala:
##########
@@ -43,7 +47,8 @@ class CometToPrettyStringSuite extends CometFuzzTestBase {
val analyzed = spark.sessionState.analyzer.execute(plan)
val result: DataFrame = Dataset.ofRows(spark, analyzed)
CometCast.isSupported(field.dataType, DataTypes.StringType,
Some(spark.sessionState.conf.sessionLocalTimeZone), CometEvalMode.TRY) match {
- case _: Compatible => checkSparkAnswerAndOperator(result)
+ case _: Compatible if
cometScanTypeChecker.isTypeSupported(field.dataType, scanImpl,
ListBuffer.empty) =>
Review Comment:
The `CometConf.COMET_NATIVE_SCAN_IMPL.get()` method gets the configuration
value from SQLConf at runtime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
