comphead commented on code in PR #2599:
URL: https://github.com/apache/datafusion-comet/pull/2599#discussion_r2442519929
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -268,41 +268,13 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
- val COMET_MEMORY_OVERHEAD: OptionalConfigEntry[Long] =
conf("spark.comet.memoryOverhead")
+ val COMET_ONHEAP_MEMORY_OVERHEAD: ConfigEntry[Long] =
conf("spark.comet.memoryOverhead")
.category(CATEGORY_TESTING)
.doc(
"The amount of additional memory to be allocated per executor process
for Comet, in MiB, " +
- "when running Spark in on-heap mode. " +
- "This config is optional. If this is not specified, it will be set to
" +
- s"`spark.comet.memory.overhead.factor` * `spark.executor.memory`.
$TUNING_GUIDE.")
- .internal()
+ "when running Spark in on-heap mode.")
Review Comment:
Should we add default value in the doc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
