avantgardnerio commented on code in PR #18029:
URL: https://github.com/apache/datafusion/pull/18029#discussion_r2429070422
##########
datafusion/physical-optimizer/src/limit_pushdown_past_window.rs:
##########
@@ -51,83 +79,62 @@ impl PhysicalOptimizerRule for LimitPushPastWindows {
if !config.optimizer.enable_window_limits {
return Ok(original);
}
- let mut latest_limit: Option<usize> = None;
- let mut latest_max = 0;
+ let mut ctx = TraverseState::default();
Review Comment:
I was also of two minds on this. I think it's easier to reason about, debug,
and disable as a separate rule, but then interplay between lots of optimizer
rules can be really difficult to debug as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
