vegarsti commented on PR #17891: URL: https://github.com/apache/datafusion/pull/17891#issuecomment-3383109032
Updated benchmark results: ``` # ./bench.sh compare main convert-array-to-scalar-vec-optional Comparing main and convert-array-to-scalar-vec-optional -------------------- Benchmark tpch_sf1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ convert-array-to-scalar-vec-optional ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩ │ QQuery 1 │ 75.02 ms │ 82.32 ms │ 1.10x slower │ │ QQuery 2 │ 21.47 ms │ 23.59 ms │ 1.10x slower │ │ QQuery 3 │ 33.10 ms │ 33.62 ms │ no change │ │ QQuery 4 │ 25.09 ms │ 25.79 ms │ no change │ │ QQuery 5 │ 53.54 ms │ 54.74 ms │ no change │ │ QQuery 6 │ 22.10 ms │ 21.65 ms │ no change │ │ QQuery 7 │ 73.68 ms │ 75.20 ms │ no change │ │ QQuery 8 │ 48.50 ms │ 51.83 ms │ 1.07x slower │ │ QQuery 9 │ 65.69 ms │ 69.89 ms │ 1.06x slower │ │ QQuery 10 │ 48.25 ms │ 70.61 ms │ 1.46x slower │ │ QQuery 11 │ 16.03 ms │ 22.89 ms │ 1.43x slower │ │ QQuery 12 │ 32.05 ms │ 42.65 ms │ 1.33x slower │ │ QQuery 13 │ 37.23 ms │ 49.70 ms │ 1.33x slower │ │ QQuery 14 │ 26.97 ms │ 28.86 ms │ 1.07x slower │ │ QQuery 15 │ 38.11 ms │ 43.25 ms │ 1.13x slower │ │ QQuery 16 │ 14.98 ms │ 15.13 ms │ no change │ │ QQuery 17 │ 95.52 ms │ 97.41 ms │ no change │ │ QQuery 18 │ 104.07 ms │ 116.01 ms │ 1.11x slower │ │ QQuery 19 │ 44.68 ms │ 60.98 ms │ 1.36x slower │ │ QQuery 20 │ 33.32 ms │ 37.44 ms │ 1.12x slower │ │ QQuery 21 │ 77.52 ms │ 90.87 ms │ 1.17x slower │ │ QQuery 22 │ 11.18 ms │ 12.07 ms │ 1.08x slower │ └──────────────┴───────────┴──────────────────────────────────────┴──────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩ │ Total Time (main) │ 998.12ms │ │ Total Time (convert-array-to-scalar-vec-optional) │ 1126.51ms │ │ Average Time (main) │ 45.37ms │ │ Average Time (convert-array-to-scalar-vec-optional) │ 51.20ms │ │ Queries Faster │ 0 │ │ Queries Slower │ 15 │ │ Queries with No Change │ 7 │ │ Queries with Failure │ 0 │ └─────────────────────────────────────────────────────┴───────────┘ ``` cc @Jefffrey This looks to me like the more explicit approach you suggested in https://github.com/apache/datafusion/pull/17891/files/e23271991bb2726df3ced25011cff0b08501b7b0#r2412895340 (which I like) made the performance drop -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
