timsaucer commented on code in PR #1274:
URL: 
https://github.com/apache/datafusion-python/pull/1274#discussion_r2429260289


##########
python/tests/test_dataframe.py:
##########
@@ -274,6 +274,31 @@ def test_filter(df):
     assert result.column(2) == pa.array([5])
 
 
+def test_parse_sql_expr(df):
+    df1 = df.filter(df.parse_sql_expr("a > 2")).select(

Review Comment:
   ```suggestion
       plan1 = df.filter(df.parse_sql_expr("a > 2")).logical_plan()
       plan2 = df.filter(column("a") > literal(2)).logical_plan()
       # object equality not implemented but string representation should match
       assert str(plan1) == str(plan2)
   
       df1 = df.filter(df.parse_sql_expr("a > 2")).select(
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to