killzoner commented on PR #1328: URL: https://github.com/apache/datafusion-ballista/pull/1328#issuecomment-3409805028
> > Example of failing check with MSRV downgraded: > > [killzoner@6d7022f](https://github.com/killzoner/datafusion-ballista/commit/6d7022f9f196f605b0eb4e91c947ef903263ee40) > > https://github.com/killzoner/datafusion-ballista/actions/runs/18509960270/job/52748285312#step:5:636 > > ```shell > > Current project MSRV: 1.85.0 > > > > thread 'main' panicked at src/main.rs:60:17: > > > > package 'datafusion' has MSRV 1.86.0 not compatible with current project MSRV 1.85.0 > > ``` > > I see, should it be other way around I wonder. We need to support MSRV which datafusion supports or older It's a bit counter intuitive yes, but apparently this is well this way See usage in `cargo add` (https://github.com/rust-lang/cargo/blob/367fd9f213750cd40317803dd0a5a3ce3f0c676d/src/cargo/ops/cargo_add/mod.rs#L947) and other places (https://github.com/rust-lang/cargo/blob/367fd9f213750cd40317803dd0a5a3ce3f0c676d/src/cargo/ops/cargo_update.rs#L754) Basically whenever we update a dependency (here `datafusion`), we should make sure to adjust the one in ballista reflecting the new potentiel MSRV from the dependencies -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
