timsaucer commented on issue #1283: URL: https://github.com/apache/datafusion-python/issues/1283#issuecomment-3423358476
Related to https://github.com/apache/datafusion/issues/17374 Right now the FFI implementation is not stable. The best advice I can give is that you should keep your rust datafusion version and your python datafusion version at the same major level. Not *every* version has had a breaking change, but I do expect more to come. In fact, I have a PR I've been working on for a week or so that will be a big change, but in the long term a very useful one IMO. I'm trying to think of a better way to convey what are the breaking changes between FFI versions, but I haven't come up with any great ideas yet. I'm open to any suggestions. At rerun we've gone the route of adding a checking for versions: https://github.com/rerun-io/rerun/blob/e6411c2eb1cfcf0a675fc5f69051fb3be1f955ad/rerun_py/rerun_sdk/rerun/catalog.py#L31 https://github.com/rerun-io/rerun/blob/e6411c2eb1cfcf0a675fc5f69051fb3be1f955ad/rerun_py/src/catalog/catalog_client.rs#L37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
