theirix commented on PR #18032: URL: https://github.com/apache/datafusion/pull/18032#issuecomment-3423874110
Now it supports all four decimal types. The shared implementation in `utils.rs` is also updated to support for all math functions. Unfortunately, it was not possible to make a generic implementation for `DecimalType`. I thought about splitting implementations for `ArrowNumericType` and `DecimalType` to include post-processing only for one of them, but it didn't work properly with types. Made an implementation with macro. Also, I discovered that a default-constructed decimal type always has scale 10, which is not what we want for operations on `ArrowPrimitiveType::Native`. Added descaling to zero, leaving underlying data as-is. Finally, `ScalarUDFImpl::signature` doesn't work great with parametrized types, so it's unclear how to specify decimals there. It is not only informational, but also used to coerce types, I suppose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
