comphead commented on code in PR #2604:
URL: https://github.com/apache/datafusion-comet/pull/2604#discussion_r2449561676
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3204,4 +3204,15 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("test concat function - strings") {
Review Comment:
Thanks @andygrove this PR for string only
ArrayType waits for https://github.com/apache/datafusion/issues/18020
I dont see binary type support though
https://spark.apache.org/docs/latest/api/sql/#concat
UPD: Binary it is probably a specific case of array concat
```
scala> spark.sql("select concat(to_binary('abc'),
to_binary('def'))").show(false)
+--------------------------------------+
|concat(to_binary(abc), to_binary(def))|
+--------------------------------------+
|[0A BC 0D EF] |
+--------------------------------------+
```
I'll check this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
