pepijnve commented on PR #17813: URL: https://github.com/apache/datafusion/pull/17813#issuecomment-3429665087
> The props only really hold the session start time, so the default execution props will interfere with evaluating now() type expressions, but not much else The concern I had with this is that you don't want strange bugs happening because of const evaluation getting confused due to the value of `now()`. Would it be acceptable to change `query_execution_start_time: DateTime<Utc>` to `query_execution_start_time: Option<DateTime<Utc>>`? That way you can at least detect access to the uninitialised value and return an `Err` instead of quietly using the wrong value. The other bit of data in ExecutionProps is the var_providers stuff. I can't quite figure out what the actual intended usage of that is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
