andygrove commented on issue #2636:
URL: 
https://github.com/apache/datafusion-comet/issues/2636#issuecomment-3437704537

   > My understanding of the situation:
   > 
   >     * `native_comet` scan tries to dictionary-encoded string columns. But 
I think they then immediately get unpacked by a CopyExec.
   
   This was also my understanding, but it is not (always) true.
   
   We sometimes inject a `CopyExec`, but only for certain operators. We were 
not injecting one for projections, causing a runtime error for any expressions 
that do not support dictionary-encoded strings, such as `regexp_replace`, and 
there are others.
   
   > My long term goal is to get us to Uft8View support and drop 
dictionary-encoded query processing since that brings Comet into alignment with 
DataFusion and Arrow-rs, but I am happy to discuss.
   
   Sounds good to me.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to