adriangb commented on PR #18307: URL: https://github.com/apache/datafusion/pull/18307#issuecomment-3452947919
I also did try a couple different sizes of `ndv/fpp` and found that at 10k/1% TPCH SF10 performance went down, I believe because of overhead of building the bloom filter. But at 1k/5% there is no noticeable difference, and it still works well for the other query. It would make sense to try to set `ndv` based on statistics (either the estimated ndv of the table or something like min(num_rows / 1000, 10_000)`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
