alamb commented on PR #16916: URL: https://github.com/apache/datafusion/pull/16916#issuecomment-3453338913
> Hi @alamb and @yazanmashal03, > > I see that PR #16916 has become stale. I'd like to help move this forward. > > Based on @alamb's feedback, I plan to create a new PR that: Runs `cargo fmt -- --config format_code_in_doc_comments=true` to format all doc comment examples and keep this as a one-time manual formatting fix > > Does this approach sound good? Please let me know if you have any concerns, and I'll start working on it! > > Thanks! Yes, that would be good To assist us in reviewing, can you please break it up as follows: 1. Format individual crates (like `datafusion` and `datafusion-datasource`) or collections of crates (e.g. `datafusion-functions-*`) in individual PRs -- we will be much faster to review 10 200 line PRs than 1 2000 line PR I believe 2. A final PR that enables the CI check to ensure no new tests are added without formatting Thank you ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
