gabotechs commented on PR #17866: URL: https://github.com/apache/datafusion/pull/17866#issuecomment-3455104887
Code LGTM, however the aggressive MSVR in `substrait-rs` seems like a problem. If we merge this, it will force anyone using DataFusion and a Rust version of 1.87 to upgrade to 1.88. TBH the MSVR bump in `substrait-rs` from https://github.com/substrait-io/substrait-rs/pull/391/commits/3a7c0cc9aec3729fae2303aa0af2cc499aa1f243 (Sep 14) seems like a bit too rushed, as 1.88 was release just a couple of months before that commit. Options that I see is: - Contribute to https://github.com/substrait-io/substrait-rs a downgrade of the MSVR and benefit from that here. - Wait for the release of 1.91 (30 Oct https://releases.rs/docs/1.91.0/), bump DataFusion's MSVR, and rebase this PR with `main` As 1.91 will just be released in a couple of days, I'd advocate for waiting until DataFusion's MSVR is set to 1.88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
