2010YOUY01 commented on code in PR #18321:
URL: https://github.com/apache/datafusion/pull/18321#discussion_r2469149700
##########
datafusion/datasource-parquet/src/row_group_filter.rs:
##########
@@ -215,10 +215,10 @@ impl RowGroupAccessPlanFilter {
};
if prune_group {
- metrics.row_groups_pruned_bloom_filter.add(1);
+ metrics.row_groups_pruned_bloom_filter.add_pruned(1);
self.access_plan.skip(idx)
- } else if !stats.column_sbbf.is_empty() {
Review Comment:
Before `row_groups_matched_bloom_filter` is not incremented if bf is not
available, I think `matched` means not able to prune in the current stage, and
this range should be further checked, so this should also be incremented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
