gabotechs commented on code in PR #18331:
URL: https://github.com/apache/datafusion/pull/18331#discussion_r2470115130


##########
Cargo.toml:
##########
@@ -183,6 +183,11 @@ testcontainers-modules = { version = "0.13" }
 tokio = { version = "1.48", features = ["macros", "rt", "sync"] }
 url = "2.5.7"
 
+# Temporary override: pull apache-avro from upstream to include unreleased 
fixes.
+# TODO: remove once the next version of apache-avro is published to crates.io 
and includes commit 3b202c5.
+[patch.crates-io]
+apache-avro = { git = "https://github.com/apache/avro-rs";, rev = 
"3b202c58f12bd1217eccf8a0028e4176ee4aadf9" }

Review Comment:
   It would be nice to see if a new proper release of `apache-avro` can be 
shipped to crates.io in order to let this just be a normal dependency. There 
seems to be a PR that tries to do this already 
https://github.com/apache/datafusion/pull/17509.
   
   I see that @timsaucer moved `apache-avro` from `xz2` to `libzma` here 
https://github.com/apache/avro-rs/commit/3b202c58f12bd1217eccf8a0028e4176ee4aadf9
 (10 Sep). 
   
   If https://github.com/apache/avro-rs in fact follows a 2 month release 
cadence, we should be seeing a new version on crates.io very soon (last release 
was 25 Aug, 2 months and 3 days ago)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to