alamb commented on code in PR #18356:
URL: https://github.com/apache/datafusion/pull/18356#discussion_r2477517973
##########
datafusion/functions/src/datetime/date_trunc.rs:
##########
@@ -482,9 +482,20 @@ fn general_date_trunc_array_fine_granularity<T:
ArrowTimestampType>(
if let Some(unit) = unit {
let original_type = array.data_type();
- let array = arrow::compute::cast(array, &DataType::Int64)?;
- let array = arrow::compute::kernels::numeric::div(&array, &unit)?;
+ let input = arrow::compute::cast(array, &DataType::Int64)?;
+ let array = arrow::compute::kernels::numeric::div(&input, &unit)?;
let array = arrow::compute::kernels::numeric::mul(&array, &unit)?;
+ // For timestamps before 1970-01-01T00:00:00Z (negative values)
+ // it is possible that the truncated value is actually later
+ // than the original value. Correct any such cases by
+ // subtracting `unit`.
+ let too_late = arrow::compute::kernels::cmp::gt(&array, &input)?;
+ let array = if too_late.true_count() > 0 {
+ let earlier = arrow::compute::kernels::numeric::sub(&array,
&unit)?;
+ arrow::compute::kernels::zip::zip(&too_late, &earlier, &array)?
+ } else {
+ array
+ };
Review Comment:
> https://github.com/apache/datafusion/pull/18360 goes further with
try_unary_mut_or_clone. that's the part orthogonal to semantic fix and can be a
follow-up
Agreed -- I will work on that as a follow up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
