alexander-beedie opened a new pull request, #2081: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2081
The bitwise "NOT" operator `"~"` is currently gated behind the PostgreSQL dialect, and is given the enum value `PGBitwiseNot`. However, this operator (with the same meaning) is actually _extremely_ common across a wide range of SQL dialects; for example: * Databricks [[docs](https://docs.databricks.com/aws/en/sql/language-manual/functions/tildesign)] * Spark SQL [[docs](https://spark.apache.org/docs/latest/sql-ref-operators.html#operators)] * DuckDB [[docs](https://duckdb.org/docs/stable/sql/functions/numeric#numeric-operators)] * BigQuery [[docs](https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/operators)] * SQLite [[docs](https://www.sqlite.org/lang_expr.html)] * MariaDB [[docs](https://mariadb.com/docs/server/reference/sql-functions/secondary-functions/bit-functions-and-operators/bitwise-not)] * MySQL [[docs](https://dev.mysql.com/doc/refman/en/bit-functions.html)] * SQL Server [[docs](https://learn.microsoft.com/en-us/sql/t-sql/language-elements/bitwise-not-transact-sql)] * RisingWave [[docs](https://docs.risingwave.com/sql/functions/mathematical#mathematical-operators)] * Vertica [[docs](https://docs.vertica.com/25.3.x/en/sql-reference/language-elements/operators/bitwise-operators/)] * _etc..._ Given the degree of backend implementation, it seems worth bringing it out from behind the PostgreSQL dialect-gate and renaming the enum value to the more generic `BitwiseNot` instead of `PGBitwiseNot`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
