asolimando commented on code in PR #18404:
URL: https://github.com/apache/datafusion/pull/18404#discussion_r2481934327
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1025,6 +1031,46 @@ impl ExecutionPlan for AggregateExec {
fn cardinality_effect(&self) -> CardinalityEffect {
CardinalityEffect::LowerEqual
}
+
Review Comment:
Could you add a few test to verify that:
1) this doesn't get pushed down (`a` missing in the second grouping set)
```
SELECT a, b, COUNT(*)
FROM table
WHERE $FILTER(a)
GROUP BY GROUPING SETS ((a, b), (b))
```
2) this gets pushed down:
```
SELECT a, b, COUNT(*)
FROM table
WHERE $FILTER(b)
GROUP BY GROUPING SETS ((a, b), (b))
```
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
