alamb commented on issue #18411: URL: https://github.com/apache/datafusion/issues/18411#issuecomment-3473978781
Here are some sampling results: Profile with samply: ```shell samply record -- datafusion-cli -c "select l_returnflag,l_linestatus, count(*) as count_order from 'lineitem.parquet' group by l_returnflag, l_linestatus;" ``` <img width="1421" height="1001" alt="Image" src="https://github.com/user-attachments/assets/e96ff99f-02ea-4cbe-8e7a-202e239d9ed7"; /> Looks to me like there are some obvious room for improvement in the code: https://github.com/apache/datafusion/blob/057583d5c02fb6b555bdd64b87cf596daa05d70f/datafusion/physical-plan/src/aggregates/group_values/multi_group_by/bytes_view.rs#L225-L237 1. Special case when there are no null values to skip the null check (there are no nulls in tpch data) 2. skip bounds check when accessing view value There are probably other ways to make this faster too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
