alamb commented on code in PR #18397:
URL: https://github.com/apache/datafusion/pull/18397#discussion_r2482655161
##########
datafusion/expr/src/udaf.rs:
##########
@@ -329,9 +329,9 @@ impl AggregateUDF {
self.inner.supports_null_handling_clause()
}
- /// See [`AggregateUDFImpl::is_ordered_set_aggregate`] for more details.
- pub fn is_ordered_set_aggregate(&self) -> bool {
- self.inner.is_ordered_set_aggregate()
+ /// See [`AggregateUDFImpl::supports_within_group_clause`] for more
details.
+ pub fn supports_within_group_clause(&self) -> bool {
Review Comment:
this is a breaking API change, as you have pointed out in the PR description
and upgrade guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
