Jefffrey commented on code in PR #18322:
URL: https://github.com/apache/datafusion/pull/18322#discussion_r2483062173
##########
datafusion/spark/src/function/bitwise/bit_count.rs:
##########
@@ -147,12 +155,26 @@ fn spark_bit_count(value_array: &[ArrayRef]) ->
Result<ArrayRef> {
}
}
+// Here’s the equivalent Rust implementation of the bitCount function (similar
to Apache Spark's bitCount for LongType)
+// Spark:
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala#L243
+// Java impl:
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/Long.java#L1584
Review Comment:
```suggestion
// Spark:
https://github.com/apache/spark/blob/ac717dd7aec665de578d7c6b0070e8fcdde3cea9/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/bitwiseExpressions.scala#L243
// Java impl:
https://github.com/openjdk/jdk/blob/d226023643f90027a8980d161ec6d423887ae3ce/src/java.base/share/classes/java/lang/Long.java#L1584
```
Permalink so we always point to the right code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
