vegarsti commented on code in PR #18432:
URL: https://github.com/apache/datafusion/pull/18432#discussion_r2484240018
##########
datafusion/functions-nested/src/extract.rs:
##########
@@ -1028,4 +1194,71 @@ mod tests {
fixed_size_list_type
);
}
+
+ #[test]
Review Comment:
Nice tests! This PR for reverse of `FixedSizeList` also added sqllogictest
cases
https://github.com/apache/datafusion/pull/16423/files#diff-317c67cc9ce87268e4ccec1cb75316eed82f99ae2ffc226874e5897913ffa4c8
It doesn't look like that is currently possible for `ListView` on arrow-rs
57, as it hits this path, which did not have a branch for `ListView` at the
time of release
https://github.com/apache/arrow-rs/blob/062d766a9c3070d191d1a1fd0baca01b9d13994f/arrow-schema/src/datatype_parse.rs#L70-L96
(but it was added recently: https://github.com/apache/arrow-rs/pull/8649)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
