adriangb commented on PR #18386: URL: https://github.com/apache/datafusion/pull/18386#issuecomment-3486423955
> > Note that I believe this is also an API change so it may make sense to wait until we cut the 51 release branch (#17558 ) and then merge this one in > > Is the concern that this would otherwise interfere with a `50.4.0` release? I am actually concerned about something else: I think this is not going to be the last breaking change we make in this area of the code (I'm hoping others are more minor though) and it might be nice to get all of those in 1 release so that the upgrade is not fragmented for users and they can do it all in one go, with good pre/post examples, etc. I think I need clarification on what you meant @alamb: do you want to wait to merge this until after we cut the 51 release branch so that it doesn't end up in the 51 release or so that it does end up in the 51 release? Either one is fine by me but I think it makes sense to try and "group" breaking changes within the same area of code into a single release so that users can upgrade their code once instead of multiple times. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
