Omega359 commented on PR #18025: URL: https://github.com/apache/datafusion/pull/18025#issuecomment-3486642351
Overall this PR is quite thorough. Beyond a small test addition and perhaps the removal of a #[allow(dead_code] attribute I think this is good to merge. I still have two todo's to file tickets in arrow-rs for making parse_fixed_offset pub and Tz::from_str to be case insensitive which I hope to get to this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
