Omega359 commented on code in PR #18025: URL: https://github.com/apache/datafusion/pull/18025#discussion_r2490997283
########## datafusion/functions/src/datetime/common.rs: ########## @@ -142,6 +647,7 @@ pub(crate) fn string_to_datetime_formatted<T: TimeZone>( /// [`chrono::format::strftime`]: https://docs.rs/chrono/latest/chrono/format/strftime/index.html /// #[inline] +#[allow(dead_code)] Review Comment: I see 5 usages of this function .. not sure why dead_code would be required here. The /dev/rust_lint.sh script doesn't complain when I remove it either -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
