feniljain opened a new pull request, #18488: URL: https://github.com/apache/datafusion/pull/18488
## Which issue does this PR close? - Closes #18409 ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Adding a distinct element calculator in core hash join loop, is this acceptable? It also works on an assumption that indices will be return in increasing order, I couldn't see a place where this assumption is broken, but if that's not the case, please do help me out. Also I am not 100% sure my implementation for `avg_fanout` is correct, so do let me know if that needs changes. ## Are these changes tested? No failures in sqllogictest, should I add a test case for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
