rluvaton commented on PR #2604: URL: https://github.com/apache/datafusion-comet/pull/2604#issuecomment-3488221678
> In case anyone is wondering why more operators are now running natively, even though the TPC-DS queries do not contain `concat` ... Spark adds concats in aggregates and Comet was previously falling back to Spark: > > ``` > :- HashAggregate [COMET: concat is not supported, Unsupported result expressions found in: Vector(MakeDecimal(sum(UnscaledValue(sales_price#3596))#3818L,17,2) AS sales#3606, MakeDecimal(sum(UnscaledValue(return_amt#3598))#3820L,17,2) AS returns#3608, (MakeDecimal(sum(UnscaledValue(profit#3597))#3819L,17,2) - MakeDecimal(sum(UnscaledValue(net_loss#3599))#3821L,17,2)) AS profit#3584, store channel AS channel#3840, concat(store, s_store_id#3856) AS id#3841)] > ``` concat exists in the query no: https://github.com/apache/datafusion-benchmarks/blob/c472383a2e0570c85766cd8ec946614dd4fda542/tpcds/queries-spark/q5.sql#L105 but spark just move it to aggregate avoid copying more data perhaps? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
